Skip to content

small fix: Packaging version switch #2315

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2023
Merged

small fix: Packaging version switch #2315

merged 1 commit into from
Sep 12, 2023

Conversation

gs-olive
Copy link
Collaborator

  • Versioning does not recognize 2.1.0+cu118 as equal to 2.1.0. Switch implementation to use less-than comparison

@gs-olive gs-olive self-assigned this Sep 12, 2023
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: torch_compile labels Sep 12, 2023
@github-actions github-actions bot requested a review from peri044 September 12, 2023 18:26
github-actions[bot]
github-actions bot approved these changes Sep 12, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Sep 12, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

peri044
peri044 approved these changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peri044 peri044 merged commit 10917bf into main Sep 12, 2023
@gs-olive gs-olive deleted the minor_packaging_fix branch September 12, 2023 19:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@peri044 peri044 peri044 approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@gs-olive gs-olive

Labels
cla signed component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: torch_compile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gs-olive @peri044 @facebook-github-bot