Skip to content

feat: Add aten.unbind decomposition for VIT #2430

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2023
Merged

feat: Add aten.unbind decomposition for VIT #2430

merged 1 commit into from
Nov 2, 2023

Conversation

gs-olive
Copy link
Collaborator

@gs-olive gs-olive commented Nov 2, 2023

Description

  • Provides full coverage for VIT operators in Dynamo

Type of change

  • Decomposition addition

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ - ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: lowering Issues re: The lowering / preprocessing passes labels Nov 2, 2023
@github-actions github-actions bot requested a review from narendasan November 2, 2023 00:01
peri044
peri044 approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peri044 peri044 merged commit 7c462ae into pytorch:main Nov 2, 2023
gs-olive added a commit to gs-olive/TensorRT that referenced this pull request Nov 3, 2023
@gs-olive
feat: Add aten.unbind decomposition for VIT (pytorch#2430)
2549edb
@gs-olive gs-olive mentioned this pull request Nov 3, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@peri044 peri044 peri044 approved these changes

@narendasan narendasan Awaiting requested review from narendasan

Assignees
No one assigned
Labels
cla signed component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: lowering Issues re: The lowering / preprocessing passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gs-olive @peri044 @facebook-github-bot