Skip to content

fix: Docs rendering on PyTorch site #2440

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2023
Merged

fix: Docs rendering on PyTorch site #2440

merged 1 commit into from
Nov 7, 2023

Conversation

gs-olive
Copy link
Collaborator

@gs-olive gs-olive commented Nov 6, 2023 •
edited
Loading

Description

Type of change

  • Docs rendering fix

Checklist:

  • [ - ] My code follows the style guidelines of this project (You can use the linters)
  • [ - ] I have performed a self-review of my own code
  • [ - ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ - ] I have made corresponding changes to the documentation
  • [ - ] I have added tests to verify my fix or my feature
  • [ - ] New and existing unit tests pass locally with my changes
  • [ - ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive requested a review from narendasan November 6, 2023 23:52
@gs-olive gs-olive self-assigned this Nov 6, 2023
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 6, 2023
narendasan
narendasan approved these changes Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

github-actions[bot]
github-actions bot approved these changes Nov 6, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Nov 6, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Nov 6, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Nov 6, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@gs-olive gs-olive force-pushed the docs_fix branch 2 times, most recently from a3689c5 to aabb30d Compare November 7, 2023 00:28
github-actions[bot]
github-actions bot approved these changes Nov 7, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Nov 7, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Nov 7, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Nov 7, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@gs-olive
fix: Docs rendering on PyTorch site
e98de14 
- Update syntax in Docker build
github-actions[bot]
github-actions bot approved these changes Nov 7, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Nov 7, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@gs-olive gs-olive merged commit 53a0802 into main Nov 7, 2023
@gs-olive gs-olive deleted the docs_fix branch November 7, 2023 00:35
gs-olive added a commit that referenced this pull request Nov 7, 2023
@gs-olive
fix: Docs rendering on PyTorch site (#2440)
456d2bf
@gs-olive gs-olive mentioned this pull request Nov 7, 2023
Merged
peri044 pushed a commit that referenced this pull request Nov 10, 2023
@gs-olive
cherry-pick/fix: Docs rendering on PyTorch site (#2440) (#2441)
f28aee3
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@narendasan narendasan narendasan approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@gs-olive gs-olive

Labels
cla signed documentation Improvements or additions to documentation priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gs-olive @narendasan @facebook-github-bot