Skip to content

chore: fix docs for export [release/2.1] #2448

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2023
Merged

chore: fix docs for export [release/2.1] #2448

merged 1 commit into from
Nov 9, 2023

Conversation

peri044
Copy link
Collaborator

@peri044 peri044 commented Nov 8, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@peri044 peri044 changed the base branch from main to release/2.1 November 8, 2023 19:35
@github-actions github-actions bot added component: api [C++] Issues re: C++ API component: build system Issues re: Build system documentation Improvements or additions to documentation labels Nov 8, 2023
@github-actions github-actions bot requested a review from narendasan November 8, 2023 19:35
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Nov 8, 2023
github-actions[bot]
github-actions bot approved these changes Nov 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Nov 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Nov 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Nov 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

narendasan
narendasan approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@peri044
chore: fix docs
b75d0b1 
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

chore: updates

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

chore: remove dynamo_export file since it has been moved

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

chore: updates

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

chore: updates

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
github-actions[bot]
github-actions bot approved these changes Nov 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Nov 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@peri044 peri044 merged commit ae733c6 into release/2.1 Nov 9, 2023
@peri044 peri044 deleted the docs_fix_2.1 branch November 15, 2023 07:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@narendasan narendasan narendasan approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
cla signed component: api [C++] Issues re: C++ API component: api [Python] Issues re: Python API component: build system Issues re: Build system component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths documentation Improvements or additions to documentation fx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peri044 @narendasan @facebook-github-bot