Skip to content

feat: support aten.arange.start_step dynamo converter #2505

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 7, 2023
Merged

feat: support aten.arange.start_step dynamo converter #2505

merged 3 commits into from
Dec 7, 2023

Conversation

zewenli98
Copy link
Collaborator

Description

Support aten.arange.start_step dynamo converter.

Fixes #2492

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests labels Nov 30, 2023
@github-actions github-actions bot requested a review from apbose November 30, 2023 02:07
@zewenli98 zewenli98 mentioned this pull request Nov 30, 2023
Closed
apbose
apbose reviewed Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@apbose apbose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be implemented in the evaluator instead?

gs-olive
gs-olive reviewed Dec 1, 2023
View reviewed changes
@zewenli98 zewenli98 force-pushed the arange_dynamo_converter branch from 2735856 to 9f7d304 Compare December 2, 2023 02:24
@zewenli98 zewenli98 requested review from apbose and gs-olive December 2, 2023 02:26
gs-olive
gs-olive reviewed Dec 2, 2023
View reviewed changes
@zewenli98 zewenli98 requested a review from gs-olive December 2, 2023 02:51
gs-olive
gs-olive reviewed Dec 6, 2023
View reviewed changes
@zewenli98 zewenli98 requested a review from gs-olive December 7, 2023 00:18
gs-olive
gs-olive approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Made a small comment with no action required.

@zewenli98 zewenli98 merged commit adb8c1b into pytorch:main Dec 7, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@gs-olive gs-olive gs-olive approved these changes

@apbose apbose Awaiting requested review from apbose

Assignees
No one assigned
Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aten.arange.start_step
4 participants
@zewenli98 @apbose @gs-olive @facebook-github-bot