Skip to content

fix: Repair usage of torch_executed_ops #2562

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2024
Merged

fix: Repair usage of torch_executed_ops #2562

merged 1 commit into from
Jan 3, 2024

Conversation

gs-olive
Copy link
Collaborator

Description

  • Previously, torch_executed_ops were excluded at partitioning time, but not conversion time, causing a bug with obscure usages of getitem
  • Now, torch_executed_ops are excluded at partitioning time and their converters are explicitly disabled

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive self-assigned this Dec 28, 2023
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Dec 28, 2023
@github-actions github-actions bot requested a review from narendasan December 28, 2023 02:53
@gs-olive
fix: Repair usage of torch_executed_ops
a6537cf 
- Previously, `torch_executed_ops` were excluded at partitioning time,
but not conversion time, causing a bug with obscure usages of `getitem`
- Now, `torch_executed_ops` are excluded at partitioning time and their
converters are explicitly disabled
@gs-olive gs-olive force-pushed the torch_executed_ops_fix branch from bcd0d5f to a6537cf Compare December 28, 2023 04:13
@github-actions github-actions bot added the component: tests Issues re: Tests label Dec 28, 2023
narendasan
narendasan approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gs-olive gs-olive merged commit 03c92a5 into pytorch:main Jan 3, 2024
@gs-olive gs-olive deleted the torch_executed_ops_fix branch January 3, 2024 19:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@narendasan narendasan narendasan approved these changes

Assignees

@gs-olive gs-olive

Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gs-olive @narendasan @facebook-github-bot