Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Implement FP32 accumulation for matmul #3110

Merged
merged 81 commits into from
Oct 11, 2024
Merged

feat: Implement FP32 accumulation for matmul #3110

merged 81 commits into from
Oct 11, 2024

Conversation

peri044
Copy link
Collaborator

@peri044 peri044 commented Aug 21, 2024

Description

Implement FP32 accumulation for matmul layers

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: core Issues re: The core compiler component: build system Issues re: Build system labels Aug 30, 2024
@peri044 peri044 changed the base branch from llm_examples_main to main September 3, 2024 15:02
@github-actions github-actions bot removed component: tests Issues re: Tests component: core Issues re: The core compiler component: build system Issues re: Build system labels Sep 24, 2024
@peri044 peri044 mentioned this pull request Sep 30, 2024
7 tasks
@github-actions github-actions bot added documentation Improvements or additions to documentation component: tests Issues re: Tests component: torch_compile labels Sep 30, 2024
@peri044 peri044 merged commit 38771e6 into main Oct 11, 2024
67 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: lowering Issues re: The lowering / preprocessing passes component: tests Issues re: Tests component: torch_compile documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants