Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MODULE.bazel file for NGC docker container #3156

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Conversation

apbose
Copy link
Collaborator

@apbose apbose commented Sep 11, 2024

No description provided.

Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need the torch-tensorrt-testing dependency?

Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apbose apbose force-pushed the DLFW_changes_MODULE.bazel branch from 2a20adf to efe66fb Compare November 19, 2024 18:57
python = use_extension("@rules_python//python/extensions:python.bzl", "python")
python.toolchain(
ignore_root_user_error = True,
python_version = "3.11",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be 3.12 right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the recent release I kept it as 3.11 and it went fine. Should the toolchain be 3.12? I will change to it. For 3.10, we used 3.11, so how should we as such determine the version?

@apbose apbose force-pushed the DLFW_changes_MODULE.bazel branch from 7ca3ee6 to 88d356a Compare November 19, 2024 20:14
@apbose apbose merged commit 32cc53f into main Nov 19, 2024
13 checks passed
keehyuna pushed a commit to keehyuna/TensorRT that referenced this pull request Dec 3, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants