Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix the global partitioner bug #3195

Merged
merged 3 commits into from
Oct 7, 2024
Merged

fix the global partitioner bug #3195

merged 3 commits into from
Oct 7, 2024

Conversation

lanluo-nvidia
Copy link
Collaborator

#3157

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@lanluo-nvidia lanluo-nvidia self-assigned this Sep 29, 2024
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Sep 29, 2024
@github-actions github-actions bot requested a review from peri044 September 29, 2024 23:43
@lanluo-nvidia lanluo-nvidia added the WIP Work is in progress, pull request should not be merged yet label Sep 29, 2024
@lanluo-nvidia lanluo-nvidia marked this pull request as ready for review September 30, 2024 00:59
@lanluo-nvidia lanluo-nvidia removed the WIP Work is in progress, pull request should not be merged yet label Sep 30, 2024
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have test cases for the global partitioner?

Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to me (after the prefix discussion). I have same questions as Naren

@github-actions github-actions bot added the component: tests Issues re: Tests label Oct 2, 2024
@lanluo-nvidia lanluo-nvidia merged commit ce38387 into main Oct 7, 2024
71 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cla signed component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants