Skip to content

fix: change docker img from manylinux to manylinux2_28 for all CUDA versions #3312

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

zewenli98
Copy link
Collaborator

Description

change docker img from manylinux to manylinux2_28 to fix the error version GLIBC_2.28 not found. We currently use pytorch/test-infra/.github/workflows/generate_binary_build_matrix.yml@main to build matrix. This PR replace the pytorch yml with ourselves' so that we can maintain and customize by ourselves.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@zewenli98 zewenli98 self-assigned this Dec 5, 2024
@zewenli98 zewenli98 force-pushed the customize_build_matrix_yml branch 2 times, most recently from baa7c80 to 5cd9cab Compare December 5, 2024 22:19
@zewenli98 zewenli98 force-pushed the customize_build_matrix_yml branch from 8055e3e to db20874 Compare December 5, 2024 23:50
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, we can iterate once its in main if necessary

@zewenli98
Copy link
Collaborator Author

Lgtm, we can iterate once its in main if necessary

sure. I'm going to merge it to unblock other PRs.

Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zewenli98 zewenli98 merged commit 5dbb848 into main Dec 6, 2024
65 of 72 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants