Skip to content

Convert the output type of bool operation to input type #351

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from
Closed

Convert the output type of bool operation to input type #351

wants to merge 1 commit into from

Conversation

developer0hye
Copy link
Contributor

Convert the output type of bool operation to input type

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

issue: #341

pull requests: #327

It supports operation between {float, int} tensor and bool tensor.

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

Convert the output type of bool operation to input type

Signed-off-by: yhkwon-DT01 <developer.0hye@gmail.com>
@developer0hye developer0hye reopened this Feb 19, 2021
@narendasan narendasan added the on hold PR is on hold pending another PR or feature being implemented label Mar 19, 2021
@github-actions
Copy link

This PR has not seen activity for 90 days, Remove stale label or comment or this will be closed in 10 days

@peri044
Copy link
Collaborator

peri044 commented Aug 24, 2021

We now support aten::to. .float() will be registered as a aten::to operator which results in desired output datatype. Closing this PR.

@peri044 peri044 closed this Aug 24, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
on hold PR is on hold pending another PR or feature being implemented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants