-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
bump to minimum python version to 3.10 and test 3.12 #2293
Conversation
@sdaulton has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Looks like there are 3 tutorial failures. Two of them should be resolved once the Ax PR lands. The last one seems to originate from the |
I looked into this a bit more closely. Looks like the failures happen because we're using development version of numpy 2.0 (installed with torch nightly), which changes some things with the copy kwarg. |
@saitcakmak we don't need to use the numpy 2.0 dev version though, right? Or do the torch nightlies depend on it? If not we should be able to install numpy <2.0 first and then the torch nightlies in CI |
I am guessing numpy 2.0 rc1 gets installed because the install command for pytorch nightly is |
Yeah that's definitely the reason it gets installed. But if we manually install numpy (without the |
I think removing |
removing pre did the trick. |
@sdaulton has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
.github/workflows/nightly.yml
Outdated
exclude: | ||
- os: "macos-14" | ||
python-version: "3.9" # not available for macos-14 | ||
python-version: ["3.10", "3.11", "3.12"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's not test 3.11 here? If things work for 3.10 and 3.12 they should also work for 3.11. And having 3.11 here will cost a bunch of GHA capacity (note that macos hosts are more expensive)
.github/workflows/nightly.yml
Outdated
exclude: | ||
- os: "macos-14" | ||
python-version: "3.9" # not available for macos-14 | ||
python-version: ["3.10", "3.11", "3.12"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python-version: ["3.10", "3.11", "3.12"] | |
python-version: ["3.10", "3.12"] |
.github/workflows/test.yml
Outdated
exclude: | ||
- os: "macos-14" | ||
python-version: "3.9" # not available for macos-14 | ||
python-version: ["3.10", "3.11", "3.12"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python-version: ["3.10", "3.11", "3.12"] | |
python-version: ["3.10", "3.12"] |
.github/workflows/test.yml
Outdated
exclude: | ||
- os: "macos-14" | ||
python-version: "3.9" # not available for macos-14 | ||
python-version: ["3.10", "3.11", "3.12"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python-version: ["3.10", "3.11", "3.12"] | |
python-version: ["3.10", "3.12"] |
.github/workflows/test_stable.yml
Outdated
exclude: | ||
- os: "macos-14" | ||
python-version: "3.9" # not available for macos-14 | ||
python-version: ["3.10", "3.11", "3.12"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python-version: ["3.10", "3.11", "3.12"] | |
python-version: ["3.10", "3.12"] |
.github/workflows/test_stable.yml
Outdated
exclude: | ||
- os: "macos-14" | ||
python-version: "3.9" # not available for macos-14 | ||
python-version: ["3.10", "3.11", "3.12"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python-version: ["3.10", "3.11", "3.12"] | |
python-version: ["3.10", "3.12"] |
.github/workflows/test_stable.yml
Outdated
exclude: | ||
- os: "macos-14" | ||
python-version: "3.9" # not available for macos-14 | ||
python-version: ["3.10", "3.11", "3.12"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python-version: ["3.10", "3.11", "3.12"] | |
python-version: ["3.10", "3.12"] |
.github/workflows/nightly.yml
Outdated
exclude: | ||
- os: "macos-14" | ||
python-version: "3.9" # not available for macos-14 | ||
python-version: ["3.10", "3.11", "3.12"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python-version: ["3.10", "3.11", "3.12"] | |
python-version: ["3.10", "3.12"] |
- name: Fetch all history for all tags and branches | ||
# We need to do this so setuptools_scm knows how to set the BoTorch version. | ||
run: git fetch --prune --unshallow | ||
- if: ${{ !inputs.use_stable_pytorch_gpytorch }} | ||
name: Install latest PyTorch & GPyTorch | ||
# Ax and cma are not compatible with numpy 2.0 yet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Ax and cma are not compatible with numpy 2.0 yet |
.github/workflows/test.yml
Outdated
exclude: | ||
- os: "macos-14" | ||
python-version: "3.9" # not available for macos-14 | ||
python-version: ["3.10", "3.11", "3.12"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python-version: ["3.10", "3.11", "3.12"] | |
python-version: ["3.10", "3.12"] |
.github/workflows/test.yml
Outdated
exclude: | ||
- os: "macos-14" | ||
python-version: "3.9" # not available for macos-14 | ||
python-version: ["3.10", "3.11", "3.12"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python-version: ["3.10", "3.11", "3.12"] | |
python-version: ["3.10", "3.12"] |
.github/workflows/test_stable.yml
Outdated
exclude: | ||
- os: "macos-14" | ||
python-version: "3.9" # not available for macos-14 | ||
python-version: ["3.10", "3.11", "3.12"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python-version: ["3.10", "3.11", "3.12"] | |
python-version: ["3.10", "3.12"] |
.github/workflows/test_stable.yml
Outdated
exclude: | ||
- os: "macos-14" | ||
python-version: "3.9" # not available for macos-14 | ||
python-version: ["3.10", "3.11", "3.12"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python-version: ["3.10", "3.11", "3.12"] | |
python-version: ["3.10", "3.12"] |
.github/workflows/test_stable.yml
Outdated
exclude: | ||
- os: "macos-14" | ||
python-version: "3.9" # not available for macos-14 | ||
python-version: ["3.10", "3.11", "3.12"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python-version: ["3.10", "3.11", "3.12"] | |
python-version: ["3.10", "3.12"] |
But that is not installing the nightly pytorch build though? |
@sdaulton has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Motivation
Bump minimum version of python from 3.9 -> 3.10 and start testing 3.12, since scientific python is no longer supporting py3.9: https://scientific-python.org/specs/spec-0000/
Have you read the Contributing Guidelines on pull requests?
(Write your answer here.)
Test Plan
Circle CI, running manual nightly job: https://github.com/sdaulton/botorch/actions/runs/8638469226