bump to minimum python version to 3.10 and test 3.12 #2293

sdaulton · 2024-04-10T21:57:00Z

Motivation

Bump minimum version of python from 3.9 -> 3.10 and start testing 3.12, since scientific python is no longer supporting py3.9: https://scientific-python.org/specs/spec-0000/

Have you read the Contributing Guidelines on pull requests?

(Write your answer here.)

Test Plan

Circle CI, running manual nightly job: https://github.com/sdaulton/botorch/actions/runs/8638469226

facebook-github-bot · 2024-04-10T22:14:58Z

@sdaulton has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

.github/workflows/deploy_on_release.yml

setup.py

…on_bump

saitcakmak · 2024-04-11T00:30:50Z

Looks like there are 3 tutorial failures. Two of them should be resolved once the Ax PR lands. The last one seems to originate from the cma package. It might require an upstream fix before we can land this -- or we can temporarily disable that tutorial.

saitcakmak · 2024-04-11T01:04:13Z

I looked into this a bit more closely. Looks like the failures happen because we're using development version of numpy 2.0 (installed with torch nightly), which changes some things with the copy kwarg.

Balandat · 2024-04-11T01:11:46Z

@saitcakmak we don't need to use the numpy 2.0 dev version though, right? Or do the torch nightlies depend on it? If not we should be able to install numpy <2.0 first and then the torch nightlies in CI

orials

saitcakmak · 2024-04-11T16:48:22Z

I am guessing numpy 2.0 rc1 gets installed because the install command for pytorch nightly is pip install --pre .... If --pre is not necessary, removing it could fix the issue without having to pin numpy. I recall this causing an issue with another dependency in the recent past

Balandat · 2024-04-11T16:58:26Z

Yeah that's definitely the reason it gets installed. But if we manually install numpy (without the --pre option) prior to installing torch, it shouldn't be upgrading numpy, even when installing torch with --pre option.

saitcakmak · 2024-04-11T17:02:21Z

I think removing --pre (if it works) is a cleaner solution than pinning numpy. Both in that it will not add additional commands in various places, and it won't introduce code that needs to be cleaned up later. By the time numpy 2.0 is released, we should aim to be compatible with it -- which doens't require a lot of work, as I found in CMA-ES/pycma#251. We likely have much less numpy code than cma does.

sdaulton · 2024-04-11T17:31:58Z

removing pre did the trick.

facebook-github-bot · 2024-04-11T17:32:14Z

@sdaulton has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Balandat · 2024-04-11T17:35:57Z

.github/workflows/nightly.yml

-        exclude:
-        - os: "macos-14"
-          python-version: "3.9"  # not available for macos-14
+        python-version: ["3.10", "3.11", "3.12"]


let's not test 3.11 here? If things work for 3.10 and 3.12 they should also work for 3.11. And having 3.11 here will cost a bunch of GHA capacity (note that macos hosts are more expensive)

Balandat · 2024-04-11T17:36:26Z

.github/workflows/nightly.yml

-        exclude:
-        - os: "macos-14"
-          python-version: "3.9"  # not available for macos-14
+        python-version: ["3.10", "3.11", "3.12"]


Suggested change

python-version: ["3.10", "3.11", "3.12"]

python-version: ["3.10", "3.12"]

Balandat · 2024-04-11T17:36:53Z

.github/workflows/test.yml

-        exclude:
-          - os: "macos-14"
-            python-version: "3.9"  # not available for macos-14
+        python-version: ["3.10", "3.11", "3.12"]


Suggested change

python-version: ["3.10", "3.11", "3.12"]

python-version: ["3.10", "3.12"]

Balandat · 2024-04-11T17:37:01Z

.github/workflows/test.yml

-        exclude:
-        - os: "macos-14"
-          python-version: "3.9"  # not available for macos-14
+        python-version: ["3.10", "3.11", "3.12"]


Suggested change

python-version: ["3.10", "3.11", "3.12"]

python-version: ["3.10", "3.12"]

Balandat · 2024-04-11T17:37:09Z

.github/workflows/test_stable.yml

-        exclude:
-          - os: "macos-14"
-            python-version: "3.9"  # not available for macos-14
+        python-version: ["3.10", "3.11", "3.12"]


Suggested change

python-version: ["3.10", "3.11", "3.12"]

python-version: ["3.10", "3.12"]

Balandat · 2024-04-11T17:37:18Z

.github/workflows/test_stable.yml

-        exclude:
-          - os: "macos-14"
-            python-version: "3.9"  # not available for macos-14
+        python-version: ["3.10", "3.11", "3.12"]


Suggested change

python-version: ["3.10", "3.11", "3.12"]

python-version: ["3.10", "3.12"]

Balandat · 2024-04-11T17:37:27Z

.github/workflows/test_stable.yml

-        exclude:
-        - os: "macos-14"
-          python-version: "3.9"  # not available for macos-14
+        python-version: ["3.10", "3.11", "3.12"]


Suggested change

python-version: ["3.10", "3.11", "3.12"]

python-version: ["3.10", "3.12"]

saitcakmak · 2024-04-11T17:37:36Z

.github/workflows/nightly.yml

-        exclude:
-        - os: "macos-14"
-          python-version: "3.9"  # not available for macos-14
+        python-version: ["3.10", "3.11", "3.12"]


Suggested change

python-version: ["3.10", "3.11", "3.12"]

python-version: ["3.10", "3.12"]

saitcakmak · 2024-04-11T17:38:24Z

.github/workflows/reusable_tutorials.yml

    - name: Fetch all history for all tags and branches
      # We need to do this so setuptools_scm knows how to set the BoTorch version.
      run: git fetch --prune --unshallow
    - if: ${{ !inputs.use_stable_pytorch_gpytorch }}
      name: Install latest PyTorch & GPyTorch
+      # Ax and cma are not compatible with numpy 2.0 yet


Suggested change

# Ax and cma are not compatible with numpy 2.0 yet

saitcakmak · 2024-04-11T17:38:53Z

.github/workflows/test.yml

-        exclude:
-          - os: "macos-14"
-            python-version: "3.9"  # not available for macos-14
+        python-version: ["3.10", "3.11", "3.12"]


Suggested change

python-version: ["3.10", "3.11", "3.12"]

python-version: ["3.10", "3.12"]

saitcakmak · 2024-04-11T17:39:04Z

.github/workflows/test.yml

-        exclude:
-        - os: "macos-14"
-          python-version: "3.9"  # not available for macos-14
+        python-version: ["3.10", "3.11", "3.12"]


Suggested change

python-version: ["3.10", "3.11", "3.12"]

python-version: ["3.10", "3.12"]

saitcakmak · 2024-04-11T17:39:16Z

.github/workflows/test_stable.yml

-        exclude:
-          - os: "macos-14"
-            python-version: "3.9"  # not available for macos-14
+        python-version: ["3.10", "3.11", "3.12"]


Suggested change

python-version: ["3.10", "3.11", "3.12"]

python-version: ["3.10", "3.12"]

saitcakmak · 2024-04-11T17:39:37Z

.github/workflows/test_stable.yml

-        exclude:
-          - os: "macos-14"
-            python-version: "3.9"  # not available for macos-14
+        python-version: ["3.10", "3.11", "3.12"]


Suggested change

python-version: ["3.10", "3.11", "3.12"]

python-version: ["3.10", "3.12"]

saitcakmak · 2024-04-11T17:39:49Z

.github/workflows/test_stable.yml

-        exclude:
-        - os: "macos-14"
-          python-version: "3.9"  # not available for macos-14
+        python-version: ["3.10", "3.11", "3.12"]


Suggested change

python-version: ["3.10", "3.11", "3.12"]

python-version: ["3.10", "3.12"]

Balandat · 2024-04-11T17:40:49Z

removing pre did the trick.

But that is not installing the nightly pytorch build though?

facebook-github-bot · 2024-04-11T18:05:30Z

@sdaulton has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2024-04-11T18:50:43Z

@sdaulton merged this pull request in 404d869.

bump to py 3.10

76cf7b5

sdaulton requested review from Balandat and esantorella April 10, 2024 21:57

facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Apr 10, 2024

sdaulton added 2 commits April 10, 2024 15:11

fix test for 3.12

6c90e3d

lint

31d2639

saitcakmak requested changes Apr 10, 2024

View reviewed changes

.github/workflows/deploy_on_release.yml Outdated Show resolved Hide resolved

.github/workflows/deploy_on_release.yml Show resolved Hide resolved

setup.py Outdated Show resolved Hide resolved

sdaulton added 2 commits April 10, 2024 16:39

lint

ca4047c

Merge branch 'version_bump' of github.com:sdaulton/botorch into versi…

80a1b34

…on_bump

saitcakmak mentioned this pull request Apr 11, 2024

Numpy 2.0 compatibility CMA-ES/pycma#251

Merged

sdaulton added 2 commits April 11, 2024 09:28

set numpy version for tut

194c4d9

orials

fix

2c14f45

remove pre

47b475d

Balandat requested changes Apr 11, 2024

View reviewed changes

saitcakmak approved these changes Apr 11, 2024

View reviewed changes

update per comments

1c486cd

facebook-github-bot closed this in 404d869 Apr 11, 2024

facebook-github-bot added the Merged label Apr 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bump to minimum python version to 3.10 and test 3.12 #2293

bump to minimum python version to 3.10 and test 3.12 #2293

sdaulton commented Apr 10, 2024 •

edited

Loading

facebook-github-bot commented Apr 10, 2024

saitcakmak commented Apr 11, 2024

saitcakmak commented Apr 11, 2024

Balandat commented Apr 11, 2024

saitcakmak commented Apr 11, 2024

Balandat commented Apr 11, 2024

saitcakmak commented Apr 11, 2024

sdaulton commented Apr 11, 2024

facebook-github-bot commented Apr 11, 2024

Balandat Apr 11, 2024

Balandat Apr 11, 2024

Balandat Apr 11, 2024

Balandat Apr 11, 2024

Balandat Apr 11, 2024

Balandat Apr 11, 2024

Balandat Apr 11, 2024

saitcakmak Apr 11, 2024

saitcakmak Apr 11, 2024

saitcakmak Apr 11, 2024

saitcakmak Apr 11, 2024

saitcakmak Apr 11, 2024

saitcakmak Apr 11, 2024

saitcakmak Apr 11, 2024

Balandat commented Apr 11, 2024

facebook-github-bot commented Apr 11, 2024

facebook-github-bot commented Apr 11, 2024

	python-version: ["3.10", "3.11", "3.12"]
	python-version: ["3.10", "3.12"]

bump to minimum python version to 3.10 and test 3.12 #2293

bump to minimum python version to 3.10 and test 3.12 #2293

Conversation

sdaulton commented Apr 10, 2024 • edited Loading

Motivation

Have you read the Contributing Guidelines on pull requests?

Test Plan

facebook-github-bot commented Apr 10, 2024

saitcakmak commented Apr 11, 2024

saitcakmak commented Apr 11, 2024

Balandat commented Apr 11, 2024

saitcakmak commented Apr 11, 2024

Balandat commented Apr 11, 2024

saitcakmak commented Apr 11, 2024

sdaulton commented Apr 11, 2024

facebook-github-bot commented Apr 11, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Balandat commented Apr 11, 2024

facebook-github-bot commented Apr 11, 2024

facebook-github-bot commented Apr 11, 2024

sdaulton commented Apr 10, 2024 •

edited

Loading