Fix posterior with observation noise in batched MTGP models #2782
+44
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D71643890 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2782 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 202 202
Lines 18518 18518
=======================================
Hits 18517 18517
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
saitcakmak
force-pushed
the
export-D71643890
branch
from
303fbd2 to
7e93bfd
Compare
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Mar 24, 2025
…2782) Summary: Posterior call with `observation_noise=True` would fail with fully Bayesian MTGP model before this change. This diff updates the logic that applies the noise to take batch shape into account. Differential Revision: D71643890
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Mar 24, 2025
…2782) Summary: Posterior call with `observation_noise=True` would fail with fully Bayesian MTGP model before this change. This diff updates the logic that applies the noise to take batch shape into account. Differential Revision: D71643890
saitcakmak
force-pushed
the
export-D71643890
branch
from
7e93bfd to
773b1ba
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71643890 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D71643890 |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Mar 24, 2025
…2782) Summary: Pull Request resolved: pytorch#2782 Posterior call with `observation_noise=True` would fail with fully Bayesian MTGP model before this change. This diff updates the logic that applies the noise to take batch shape into account. Differential Revision: D71643890
saitcakmak
force-pushed
the
export-D71643890
branch
from
773b1ba to
90a79d8
Compare
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Mar 25, 2025
…2782) Summary: Posterior call with `observation_noise=True` would fail with fully Bayesian MTGP model before this change. This diff updates the logic that applies the noise to take batch shape into account. Differential Revision: D71643890
saitcakmak
force-pushed
the
export-D71643890
branch
from
90a79d8 to
50b3f09
Compare
…2782) Summary: Pull Request resolved: pytorch#2782 Posterior call with `observation_noise=True` would fail with fully Bayesian MTGP model before this change. This diff updates the logic that applies the noise to take batch shape into account. Differential Revision: D71643890
|
This pull request was exported from Phabricator. Differential Revision: D71643890 |
saitcakmak
force-pushed
the
export-D71643890
branch
from
50b3f09 to
d04fb4a
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Posterior call with
observation_noise=Truewould fail with fully Bayesian MTGP model before this change. This diff updates the logic that applies the noise to take batch shape into account.Differential Revision: D71643890