Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

conda recipe should use matplotlib-base #644

Closed
jamesmyatt opened this issue Apr 1, 2021 · 1 comment
Closed

conda recipe should use matplotlib-base #644

jamesmyatt opened this issue Apr 1, 2021 · 1 comment

Comments

@jamesmyatt
Copy link

jamesmyatt commented Apr 1, 2021

According to the conda-forge docs, the conda recipe should probably depend on the matplotlib-base package, rather than matplotlib: https://conda-forge.org/docs/maintainer/knowledge_base.html#matplotlib

Is this right? Does captum require pyqt as well or just matplotlib?

For example: conda-forge/geoplot-feedstock#19

@vivekmig
Copy link
Contributor

vivekmig commented Apr 5, 2021

Thanks @jamesmyatt , this is a great catch! Captum only requires matplotlib but not pyqt, we will update the recipe to depend on matplotlib-base instead.

@vivekmig vivekmig linked a pull request Apr 6, 2021 that will close this issue
facebook-github-bot pushed a commit that referenced this issue Apr 7, 2021
Summary:
This addresses #644 , switching the Conda dependency from matplotlib to matplotlib-base, since pyqt is not used in Captum.

Pull Request resolved: #648

Reviewed By: nlaptev

Differential Revision: D27604398

Pulled By: vivekmig

fbshipit-source-id: 9241a2d26b81d2232fcf801e9742e93b2238d722
@vivekmig vivekmig closed this as completed Apr 7, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants