Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

improve error msg of invalid input types #1083

Closed
wants to merge 2 commits into from
Closed

improve error msg of invalid input types #1083

wants to merge 2 commits into from

Conversation

aobo-y
Copy link
Contributor

@aobo-y aobo-y commented Dec 6, 2022

Discussed in #1077 (comment) , improving the error message of invalid inputs to tell the two types we allow: Tensor and tuple[Tensor]

vivekmig
vivekmig approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@vivekmig vivekmig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

nit: Seems like it might be necessary to run ufmt from the CircleCI results?

@NarineK
Copy link
Contributor

NarineK commented Dec 6, 2022

Conda started failing since yesterday but for ci/circleci: test_py37_conda only and there is a small formatting issue.

@aobo-y
Copy link
Contributor Author

aobo-y commented Dec 7, 2022

@NarineK I will try to solve the conda issue in another pr

@facebook-github-bot
Copy link
Contributor

@aobo-y has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@aobo-y merged this pull request in c29155b.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@vivekmig vivekmig vivekmig approved these changes

Assignees
No one assigned
Labels
cla signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aobo-y @NarineK @facebook-github-bot @vivekmig