Fix Lime output dimension in batch forward #1513
Closed
+20
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D70096644 |
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Feb 24, 2025
Summary: Currently, when a batch of inputs is provided with a forward function that returns a single scalar per batch, Lime and KernelShap still return output matching the input shape. This behavior is inconsistent with other perturbation based methods, particularly Feature Ablation and Shapley Value Sampling. This change breaks backward compatibility for OSS users, but since it's a specific case (scalar per batch), should be fine to update with only a documentation update. Differential Revision: D70096644
vivekmig
force-pushed
the
export-D70096644
branch
from
d67fb13 to
550c991
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70096644 |
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Feb 25, 2025
Summary: Currently, when a batch of inputs is provided with a forward function that returns a single scalar per batch, Lime and KernelShap still return output matching the input shape. This behavior is inconsistent with other perturbation based methods, particularly Feature Ablation and Shapley Value Sampling. This change breaks backward compatibility for OSS users, but since it's a specific case (scalar per batch), should be fine to update with only a documentation update. Reviewed By: craymichael Differential Revision: D70096644
vivekmig
force-pushed
the
export-D70096644
branch
from
550c991 to
3ba59ed
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70096644 |
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Feb 25, 2025
Summary: Currently, when a batch of inputs is provided with a forward function that returns a single scalar per batch, Lime and KernelShap still return output matching the input shape. This behavior is inconsistent with other perturbation based methods, particularly Feature Ablation and Shapley Value Sampling. This change breaks backward compatibility for OSS users, but since it's a specific case (scalar per batch), should be fine to update with only a documentation update. Reviewed By: craymichael Differential Revision: D70096644
vivekmig
force-pushed
the
export-D70096644
branch
from
3ba59ed to
172f835
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70096644 |
Summary: Currently, when a batch of inputs is provided with a forward function that returns a single scalar per batch, Lime and KernelShap still return output matching the input shape. This behavior is inconsistent with other perturbation based methods, particularly Feature Ablation and Shapley Value Sampling. This change breaks backward compatibility for OSS users, but since it's a specific case (scalar per batch), should be fine to update with only a documentation update. Reviewed By: craymichael Differential Revision: D70096644
vivekmig
force-pushed
the
export-D70096644
branch
from
172f835 to
0aae7e4
Compare
|
This pull request has been merged in a799dfd. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently, when a batch of inputs is provided with a forward function that returns a single scalar per batch, Lime and KernelShap still return output matching the input shape.
This behavior is inconsistent with other perturbation based methods, particularly Feature Ablation and Shapley Value Sampling.
This change breaks backward compatibility for OSS users, but since it's a specific case (scalar per batch), should be fine to update with only a documentation update.
Differential Revision: D70096644