Add feature ablation to Insights #319
Conversation
edward-io
commented
Mar 10, 2020
•
edward-io
commented
- add feature ablation option
There was a problem hiding this comment.
@edward-io has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
edward-io
force-pushed
the
feature-ablation-insights
branch
2 times, most recently
from
c695721 to
e459749
Compare
There was a problem hiding this comment.
@edward-io has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Thanks for adding this, looks good! I think it might be good to also add the perturbations_per_eval argument as a NumberConfig for FeatureAblation, since it very substantially affects performance, and we can often set it to a higher value depending on memory available.
edward-io
force-pushed
the
feature-ablation-insights
branch
from
e459749 to
03601d8
Compare
There was a problem hiding this comment.
@edward-io has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
edward-io
force-pushed
the
feature-ablation-insights
branch
from
03601d8 to
9f92429
Compare
There was a problem hiding this comment.
@edward-io has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
edward-io
force-pushed
the
feature-ablation-insights
branch
from
9f92429 to
a1967cb
Compare
There was a problem hiding this comment.
@edward-io has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
edward-io
force-pushed
the
feature-ablation-insights
branch
from
a1967cb to
b169a4f
Compare
|
@edward-io merged this pull request in 8312e68. |
Summary: - add feature ablation option Pull Request resolved: pytorch#319 Reviewed By: orionr Differential Revision: D20371928 Pulled By: edward-io fbshipit-source-id: ea558b14c5fcfc754ea4be4de295433965e7f1f9
