Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Occlusion to Insights #369

Closed
wants to merge 2 commits into from

Conversation

edward-io
Copy link
Contributor

image

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edward-io has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@edward-io edward-io force-pushed the insights-occlusion branch 2 times, most recently from 93a0b67 to 837a5cf Compare May 5, 2020 02:17
Copy link
Contributor

@J0Nreynolds J0Nreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there's just one question I had.

"sliding_window_shapes": StrConfig(value=""),
"strides": StrConfig(value=""),
},
post_process={
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these post-processing steps necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Occlusion takes in a tuple or an int e.g. (3, 5, 5), so we need a way to convert a string representation into the appropriate format.

@edward-io edward-io force-pushed the insights-occlusion branch 3 times, most recently from e733e7e to 47499a9 Compare May 5, 2020 19:25
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edward-io has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@edward-io edward-io force-pushed the insights-occlusion branch from 47499a9 to 545beea Compare May 11, 2020 23:22
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edward-io has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edward-io has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@edward-io
Copy link
Contributor Author

Add fix to UI config parsing

facebook-github-bot pushed a commit that referenced this pull request May 12, 2020
Summary:
Seeing this unrelated error in #369: https://circleci.com/gh/pytorch/captum/6777?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link.
Pull Request resolved: #379

Reviewed By: bilalsal

Differential Revision: D21514229

Pulled By: edward-io

fbshipit-source-id: 6a8f89807b7a9b930fcbfa2d3fe4332d91e3e5a8
@edward-io edward-io force-pushed the insights-occlusion branch from 3cd741c to 3fb83ad Compare May 12, 2020 21:44
@edward-io edward-io force-pushed the insights-occlusion branch from 3fb83ad to d0a8800 Compare May 12, 2020 21:52
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edward-io has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@edward-io
Copy link
Contributor Author

add perturbations_per_eval as a config option to occlusion

@facebook-github-bot
Copy link
Contributor

@edward-io merged this pull request in c2062db.

NarineK pushed a commit to NarineK/captum-1 that referenced this pull request Nov 19, 2020
Summary:
Seeing this unrelated error in pytorch#369: https://circleci.com/gh/pytorch/captum/6777?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link.
Pull Request resolved: pytorch#379

Reviewed By: bilalsal

Differential Revision: D21514229

Pulled By: edward-io

fbshipit-source-id: 6a8f89807b7a9b930fcbfa2d3fe4332d91e3e5a8
NarineK pushed a commit to NarineK/captum-1 that referenced this pull request Nov 19, 2020
Summary:
![image](https://user-images.githubusercontent.com/53842584/81026858-6efefb00-8e30-11ea-970d-5c6907fe3e7b.png)
Pull Request resolved: pytorch#369

Reviewed By: vivekmig, J0Nreynolds

Differential Revision: D21394665

Pulled By: edward-io

fbshipit-source-id: 4f6848928fa271b99ee8a376b6232985fc739b2c
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants