Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

support empty inputs in Lime & KernelShap #812

Closed
wants to merge 2 commits into from

Conversation

aobo-y
Copy link
Contributor

@aobo-y aobo-y commented Dec 4, 2021

Empty inputs work in methods like FeatureAblation & ShapleyValueSampling, but not in Lime and KernelShap.
This update correctly handles empty tensors like tensor([[],[],[]]) whose shape is (3,0) in Lime and KernelShap.
Added corresponding tests.

@facebook-github-bot
Copy link
Contributor

@aobo-y has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@aobo-y aobo-y requested review from vivekmig and NarineK December 4, 2021 01:53
Copy link
Contributor

@vivekmig vivekmig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for fixing this!

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants