Skip to content

Make a separate target for kernel utils #10788

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Make a separate target for kernel utils #10788

wants to merge 10 commits into from

Conversation

kirklandsign
Copy link
Contributor

@kirklandsign kirklandsign commented May 9, 2025 •
edited
Loading

Currently it's built into portable kernels only. Other kernels used it, and the runner must include portable kernel to avoid undefined symbols. We need to split these utils out. A fix for #10677 without BC breaking.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 9, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10788

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 4675d97 with merge base 6e959be (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 9, 2025
@kirklandsign kirklandsign added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label May 9, 2025
@kirklandsign kirklandsign changed the title test Make a separate target for kernel utils May 9, 2025
@kirklandsign kirklandsign marked this pull request as ready for review May 9, 2025 21:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@manuelcandales manuelcandales Awaiting requested review from manuelcandales manuelcandales is a code owner

@swolchok swolchok Awaiting requested review from swolchok swolchok is a code owner

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

@jackzhxng jackzhxng Awaiting requested review from jackzhxng jackzhxng is a code owner

@iseeyuan iseeyuan Awaiting requested review from iseeyuan iseeyuan is a code owner

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ciflow/binaries ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kirklandsign @facebook-github-bot