Skip to content

Add BroadcastIndexesRange tests with dims of size 1 in output #8964

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 31 commits into from
Mar 6, 2025
Merged

Add BroadcastIndexesRange tests with dims of size 1 in output #8964

merged 31 commits into from
Mar 6, 2025

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Mar 5, 2025

Per request from @kimishpatel.

@swolchok
Update
f1ace77 
[ghstack-poisoned]
@swolchok
Update
d3a0f67 
[ghstack-poisoned]
@swolchok
Update
a78277d 
[ghstack-poisoned]
@swolchok
Update
6b6180c 
[ghstack-poisoned]
@swolchok
Update
7cbe7a1 
[ghstack-poisoned]
@swolchok
Update
8e8ce33 
[ghstack-poisoned]
@swolchok
Update
093a6d3 
[ghstack-poisoned]
@swolchok
Update
77f039c 
[ghstack-poisoned]
@swolchok
Update
c4e4541 
[ghstack-poisoned]
@swolchok
Update
d3edbcb 
[ghstack-poisoned]
@swolchok
Update
bf96b84 
[ghstack-poisoned]
@swolchok
Update
f7e4fc9 
[ghstack-poisoned]
@swolchok
Update
90da9b1 
[ghstack-poisoned]
@swolchok
Update
29d1122 
[ghstack-poisoned]
@swolchok
Update
14a55be 
[ghstack-poisoned]
@swolchok
Update
3e20161 
[ghstack-poisoned]
@swolchok
Update
1497adb 
[ghstack-poisoned]
@swolchok
Update
8ade738 
[ghstack-poisoned]
@swolchok
Update
0a18dab 
[ghstack-poisoned]
@swolchok
Update
62ab1e7 
[ghstack-poisoned]
@swolchok
Update
a9bbae4 
[ghstack-poisoned]
@swolchok
Update
7bce689 
[ghstack-poisoned]
@swolchok
Update
d208351 
[ghstack-poisoned]
@swolchok
Update
289d53c 
[ghstack-poisoned]
@swolchok
Update
e26a958 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Mar 5, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8964

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9e4bdb2 with merge base cca6917 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@swolchok swolchok mentioned this pull request Mar 5, 2025
Closed
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 5, 2025
@swolchok swolchok mentioned this pull request Mar 5, 2025
Closed
swolchok added a commit that referenced this pull request Mar 5, 2025
@swolchok
Add BroadcastIndexesRange tests with dims of size 1 in output
36313b4 
Per request from kimishpatel.

ghstack-source-id: 0624885
ghstack-comment-id: 2701662107
Pull Request resolved: #8964
@swolchok swolchok mentioned this pull request Mar 5, 2025
Merged
swolchok added 3 commits March 5, 2025 10:04
@swolchok
Update
6893c27 
[ghstack-poisoned]
@swolchok
Update
7cc62d2 
[ghstack-poisoned]
@swolchok
Update
3c4716c 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Mar 5, 2025
@swolchok
Add BroadcastIndexesRange tests with dims of size 1 in output
50cd037 
Per request from kimishpatel.

ghstack-source-id: 6346f72
ghstack-comment-id: 2701662107
Pull Request resolved: #8964
swolchok added 3 commits March 5, 2025 10:22
@swolchok
Update
570845e 
[ghstack-poisoned]
@swolchok
Update
e52508d 
[ghstack-poisoned]
@swolchok
Update
9e4bdb2 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Mar 5, 2025
@swolchok
Add BroadcastIndexesRange tests with dims of size 1 in output
9143d3e 
Per request from kimishpatel.

ghstack-source-id: 2afd34d
ghstack-comment-id: 2701662107
Pull Request resolved: #8964
@swolchok swolchok requested a review from kimishpatel March 5, 2025 19:01
Base automatically changed from gh/swolchok/302/head to main March 6, 2025 18:37
@swolchok swolchok merged commit 607a6b9 into main Mar 6, 2025
51 checks passed
@swolchok swolchok deleted the gh/swolchok/312/head branch March 6, 2025 18:39
zonglinpeng pushed a commit that referenced this pull request Mar 6, 2025
@swolchok
Add BroadcastIndexesRange tests with dims of size 1 in output (#8964)
186b4d8 
Per request from @kimishpatel.
@github-actions github-actions bot mentioned this pull request Mar 10, 2025
Open
This was referenced Mar 17, 2025
Open
Open
@github-actions github-actions bot mentioned this pull request Mar 31, 2025
Open
@github-actions github-actions bot mentioned this pull request Apr 7, 2025
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kimishpatel kimishpatel kimishpatel approved these changes

@dbort dbort Awaiting requested review from dbort

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka

@lucylq lucylq Awaiting requested review from lucylq

@manuelcandales manuelcandales Awaiting requested review from manuelcandales manuelcandales is a code owner

@jackzhxng jackzhxng Awaiting requested review from jackzhxng

@digantdesai digantdesai Awaiting requested review from digantdesai

@tarun292 tarun292 Awaiting requested review from tarun292

@Gasoonjia Gasoonjia Awaiting requested review from Gasoonjia

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swolchok @kimishpatel @facebook-github-bot