Fix "flexible array member X not at end of struct" compiling with GCC-11 #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 24, 2023
Flamefire
reviewed
Feb 3, 2024
| } ecmd; | ||
| constexpr auto bufsize = sizeof(struct ethtool_link_settings) + sizeof(__u32)*link_mode_data_nwords; | ||
| char buf[bufsize]; | ||
| struct ethtool_link_settings& ecmd = *(struct ethtool_link_settings*)buf; |
There was a problem hiding this comment.
IMO this is technically a strict aliasing violation and hence UB. At least buf needs to be aligned as struct ethtool_link_settings and possibly a placement new needs to be used.
Idea: Using an union to enforce the size might work:
constexpr auto bufsize = sizeof(struct ethtool_link_settings) + sizeof(__u32)*link_mode_data_nwords;
union {
struct ethtool_link_settings req;
char buf[bufsize];
} ecmd;
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a problem compiling with GCC-11 (present when I compiled latest Torch which includes gloo). The problem was also reported on Debian's ML, see for full context:
https://www.mail-archive.com/debian-bugs-dist@lists.debian.org/msg1875386.html
This problem should not be occurring in the first place and it's probably a bug of GCC, but luckily the workaround is quite simple too.