Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Importer] Support arg "order" in Caffe2 Conv, MaxPool and AveragePool ops #1853

Merged
merged 1 commit into from
Oct 12, 2018
Merged

[Importer] Support arg "order" in Caffe2 Conv, MaxPool and AveragePool ops #1853

merged 1 commit into from
Oct 12, 2018

Conversation

beicy
Copy link
Contributor

@beicy beicy commented Oct 11, 2018 •
edited by rdzhabarov
Loading

Description:

Add arg "order" in Caffe2 Conv, MaxPool and AveragePool ops.
The "order" can be "NCHW" (by default) and "NHWC".

Testing:
Unittests added.

Documentation:
N/A

Needed for #1727

nadavrot
nadavrot reviewed Oct 11, 2018
View reviewed changes
tests/unittests/caffe2ImporterTest.cpp Outdated
output = caffe2LD.getSingleOutput();

ctx.allocate(mod.getPlaceholders());
updateInputsByName(ctx, &mod, {"inputs"}, {&inputs});

This comment was marked as off-topic.

# to view

This comment was marked as off-topic.

# to view

rdzhabarov
rdzhabarov approved these changes Oct 11, 2018
View reviewed changes
Copy link
Contributor

@rdzhabarov rdzhabarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

What are the nets you are looking at?

@beicy
Copy link
Contributor Author

beicy commented Oct 12, 2018

@rdzhabarov The quantized resnet50.

@qcolombet
Copy link
Contributor

Could you add tests for the NCHW order, so that we can check the transposes are properly added?

@beicy beicy merged commit cb2b12a into pytorch:master Oct 12, 2018
@beicy beicy deleted the op1 branch October 12, 2018 21:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@nadavrot nadavrot nadavrot left review comments

@rdzhabarov rdzhabarov rdzhabarov approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@beicy @qcolombet @nadavrot @rdzhabarov @facebook-github-bot