Skip to content

Commit

Permalink
Drop python 3.8 in the CI
Browse files Browse the repository at this point in the history
  • Loading branch information
vfdev-5 authored Sep 27, 2024
1 parent 3a059ce commit 853bafd
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/code-style.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
uses: actions/checkout@v4
- uses: actions/setup-python@v4
with:
python-version: "3.8"
python-version: "3.11"
- run: |
bash ./tests/run_code_style.sh install
bash ./tests/run_code_style.sh fmt
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/hvd-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
timeout-minutes: 60
strategy:
matrix:
python-version: [3.8]
python-version: [3.11]
pytorch-channel: [pytorch]

steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/mps-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
mps-tests:
strategy:
matrix:
python-version: [3.8]
python-version: [3.11]
pytorch-channel: ["pytorch"]
skip-distrib-tests: [1]
fail-fast: false
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/pytorch-version-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ jobs:
max-parallel: 5
fail-fast: false
matrix:
# Here we keep python 3.8 tests until the end of the 2024 and
# will drop python version and related pytorch versions
python-version: [3.8, 3.9, "3.10"]
pytorch-version:
[2.3.1, 2.2.2, 2.1.2, 2.0.1, 1.13.1, 1.12.1, 1.10.0, 1.8.1, 1.5.1]
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,18 +40,18 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
python-version: ["3.9", "3.10", "3.11", "3.12"]
pytorch-channel: [pytorch, pytorch-nightly]
include:
# includes a single build on windows
- os: windows-latest
pytorch-channel: pytorch
python-version: 3.9
python-version: 3.11
skip-distrib-tests: 1
# includes a single build on macosx
- os: macos-latest
pytorch-channel: pytorch
python-version: 3.9
python-version: 3.11
skip-distrib-tests: 1

steps:
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ into the following categories:
- Create an isolated conda environment for pytorch-ignite:

```bash
conda create -n pytorch-ignite-dev python=3.8
conda create -n pytorch-ignite-dev python=3.11
```

- Activate the newly created environment:
Expand Down

0 comments on commit 853bafd

Please # to comment.