Added args/kwargs to idist barrier #2353
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fco-dv
requested review from
vfdev-5 and
sdesrozis
and removed request for
vfdev-5
vfdev-5
reviewed
Dec 19, 2021
# Conflicts: # ignite/distributed/utils.py
vfdev-5
reviewed
Dec 22, 2021
Co-authored-by: vfdev <vfdev.5@gmail.com>
vfdev-5
previously approved these changes
Dec 22, 2021
|
@fco-dv looks good (approving the content), can we also add few tests of this new feature ? |
|
thanks for approving @vfdev-5 ! yes I will add some |
vfdev-5
reviewed
Dec 23, 2021
vfdev-5
reviewed
Dec 23, 2021
vfdev-5
reviewed
Jan 14, 2022
vfdev-5
reviewed
Jan 16, 2022
Co-authored-by: vfdev <vfdev.5@gmail.com>
vfdev-5
approved these changes
Jan 17, 2022
|
@fco-dv are we good and can merge it ? If OK for you please merge it by yourself. |
|
seems like |
vfdev-5
reviewed
Jan 17, 2022
|
@fco-dv what remains for this PR ? |
fco-dv
commented
Jan 25, 2022
| # hvd.allreduce(torch.tensor(0, device=self.device()), name="barrier") | ||
| hvd.allreduce(torch.tensor(0, device="cpu"), name="barrier") | ||
| else: | ||
| hvd.barrier(*args, **kwargs) |
There was a problem hiding this comment.
@vfdev-5 not a lot on this PR remaining I think, just wanted to check the hvd 2 gpus tests for this because it seems to fail here.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2213
Description: Pass args and kwargs to idist.barrier method, route it to backends
Check list: