-
-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add divergence metrics #3232
Add divergence metrics #3232
Conversation
Co-authored-by: vfdev <vfdev.5@gmail.com>
Co-authored-by: vfdev <vfdev.5@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot adding new metrics @kzkadc !
@kzkadc can you please check this failure with pytorch 1.5.1: https://github.com/pytorch/ignite/actions/runs/8730344048/job/23953994151
Looks like |
Thanks. The kl_div's behaviour in 1.5.1 is equivalent to log_target=False (default) in the current version. |
we can also make a small if-else depending on pytorch version. For example: ignite/ignite/metrics/gan/fid.py Line 15 in f431e60
Using log_target may be has better computation result stability (to confirm), so, for recent pytorch it would be better to use this option if it makes more sense to use vs keeping default |
Description: added KL and JS divergences between two categorical predictions
Check list: