-
-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
setup_logger: add optional arg encoding
for FileHandler
#3240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, the encoding is `utf-8` for compatibility with CJK characters. Signed-off-by: Shengjiang Quan <qsj287068067@126.com>
sjiang95
changed the title
setup_logger: add optional arg encoding for FileHandler
setup_logger: add optional arg Apr 23, 2024
encoding
for FileHandler
vfdev-5
reviewed
Apr 23, 2024
vfdev-5
reviewed
Apr 23, 2024
vfdev-5
reviewed
Apr 24, 2024
vfdev-5
approved these changes
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @sjiang95 !
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the encoding is
utf-8
for compatibility with CJK characters.Fixes #3239
Description:
Add an optional arg
encoding
tosetup_logger()
. By default, theencoding
isutf-8
for compatibility with CJK characters.Check list:
Test:
Can use the following script for test
In
utf8.log
while in
defaultEncode.log