Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix mps not functional #3249

Merged
merged 1 commit into from
May 22, 2024
Merged

Fix mps not functional #3249

merged 1 commit into from
May 22, 2024

Conversation

leej3
Copy link
Collaborator

@leej3 leej3 commented May 21, 2024

Tests on mac-os-latest (macos-14-arm64) failing. MPS is not available on this as far as I can tell (see here

@leej3 leej3 requested a review from vfdev-5 May 21, 2024 11:53
@github-actions github-actions bot added the module: handlers Core Handlers module label May 21, 2024
tests/utils_for_tests.py Outdated Show resolved Hide resolved
@leej3 leej3 force-pushed the fix-mps-not-functional branch from 68c26a8 to 861ff97 Compare May 21, 2024 13:21
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@vfdev-5
Copy link
Collaborator

vfdev-5 commented May 21, 2024

Still failing on macos: https://github.com/pytorch/ignite/actions/runs/9175447451/job/25228464761?pr=3249#step:15:2267

@github-actions github-actions bot added the ci CI label May 21, 2024
@leej3 leej3 force-pushed the fix-mps-not-functional branch from f5aafd5 to 8f7275f Compare May 21, 2024 16:03
@leej3 leej3 force-pushed the fix-mps-not-functional branch from 8f7275f to c98e9b1 Compare May 21, 2024 17:23
@leej3 leej3 merged commit 20d6b5b into master May 22, 2024
19 of 20 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ci CI module: handlers Core Handlers module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants