Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add MetricGroup feature #3266

Merged
merged 9 commits into from
Aug 1, 2024
Merged

Conversation

sadra-barikbin
Copy link
Collaborator

  • Initial commit
  • Add tests

Hi there!

To add MetricGroup feature.

Closes #3264

@github-actions github-actions bot added docs module: metrics Metrics module labels Jul 25, 2024
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Jul 25, 2024

Hey @sadra-barikbin thanks for the PR! Would you mind to fix the CI as well ?

@sadra-barikbin
Copy link
Collaborator Author

Seemingly it's in rouge metric, related to Nltk.

nltk/nltk#3290

nltk/nltk#3266

@github-actions github-actions bot added the module: engine Engine module label Jul 31, 2024
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sadra-barikbin, LGTM!

@vfdev-5 vfdev-5 merged commit 4c93282 into pytorch:master Aug 1, 2024
19 of 20 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
docs module: engine Engine module module: metrics Metrics module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

To introduce MetricGroup class
2 participants