-
-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add rank correlation metrics #3276
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @kzkadc , I left few comments now about how to handle the imports of scipy in the code. I'll check the tests and docs a bit later, but overall implementation looks ok to me.
Please also check code formatting, unit tests CI is also failed due to too long line |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR @kzkadc !
CI failures are unrelated, submitted a temporary fix with mlflow version constraints. Once #3278 is merged let's update this PR, rerun the CI and merge if all is green. |
Description: added Spearman and Kendall rank correlation coefficient metrics.
https://en.wikipedia.org/wiki/Spearman%27s_rank_correlation_coefficient
https://en.wikipedia.org/wiki/Kendall_rank_correlation_coefficient
Check list: