[WIP ]Added labelwise metrics with tests #542
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vfdev-5 I have at least added Accuracy with labelwise option. Wanted to further discuss Precision and Recall before implementing. |
vfdev-5
requested changes
Jun 5, 2019
There was a problem hiding this comment.
I'm not a fan of another bool flag labelwise. Idea is to introduce a new variable, e.g multilabel that takes values for example exact, labelwise, top-K with variable K (top-3, top-5 etc):
exactis currentis_multilabel=Truebehaviourlabelwiseis your implementation behaviour withlabelwise=Truetop-Kwith parsing K into an integer and computes top-k multi-label accuracy.
@anmolsjoshi what do you think ?
Old argument is_multilabel becomes deprecated and will be removed since 0.3.0
| def __init__(self, output_transform=lambda x: x, is_multilabel=False): | ||
| def __init__(self, output_transform=lambda x: x, is_multilabel=False, labelwise=False): | ||
| if labelwise and not is_multilabel: | ||
| raise ValueError("labelwise is only applicable for multilabel cases. If labelise=True, is_multilabel=True.") |
There was a problem hiding this comment.
Suggested change
| raise ValueError("labelwise is only applicable for multilabel cases. If labelise=True, is_multilabel=True.") | |
| raise ValueError("labelwise is only applicable for multilabel cases. If labelwise=True, is_multilabel=True.") |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #513 and #516
Description:
Added tests
Check list: