Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix git checkout typo in readme #212

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix git checkout typo in readme #212

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fef7206
Fix git checkout typo in readme
ezyang Oct 18, 2022
b2c7248
Update README.md
ezyang Oct 18, 2022
62c0e73
Update README.md
ezyang Oct 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,11 +143,14 @@ Both `docker` and `pip install` options above are wrappers around the `cmake bui
#### Building

```bash
# Setup deps
conda install -c conda-forge libpython-static
Copy link
Member

@d4l3k d4l3k Oct 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is mentioned in the section before

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, so like I skipped to the build from source section, it didn't work, and then I had to go back and look for it. Just put it close lol

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we just add a line about "make sure to install python static as mentioned earlier"


# checkout repo
git checkout https://github.com/pytorch/multipy.git
git submodule sync && git submodule update --init --recursive
git clone https://github.com/pytorch/multipy.git

cd multipy
git submodule sync && git submodule update --init --recursive
# install python parts of `torch::deploy` in multipy/multipy/utils
pip install -e . --install-option="--cmakeoff"

Expand All @@ -157,6 +160,7 @@ cd multipy/runtime
mkdir build
cd build
# use cmake -DABI_EQUALS_1=ON .. instead if you want ABI=1
# if you built PyTorch from source, pass -DPYTORCH_ROOT=path/to/pytorch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line isn't needed with recent changes. Also does this work given we always set it in cmake?

cmake ..
cmake --build . --config Release
```
Expand Down