Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Iteration +1: pueblo.nlp.CachedWebResource and pueblo.ngr #6

Merged
merged 7 commits into from
Oct 30, 2023
Merged

Conversation

amotl
Copy link
Member

@amotl amotl commented Oct 30, 2023

About

  • Add CachedWebResource, a wrapper around requests-cache and langchain.
  • ngr: Add test suite runner pueblo.ngr, with software tests.
  • Improve getenvpass.
  • Fix MANIFEST.in.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #6 (0c283a1) into main (4a08a02) will decrease coverage by 0.74%.
The diff coverage is 80.43%.

❗ Current head 0c283a1 differs from pull request most recent head 01f611e. Consider uploading reports for the commit 01f611e to get more accurate results

@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
- Coverage   80.24%   79.50%   -0.74%     
==========================================
  Files           6        8       +2     
  Lines          81      122      +41     
==========================================
+ Hits           65       97      +32     
- Misses         16       25       +9     
Flag Coverage Δ
unittests 79.50% <80.43%> (-0.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pueblo/context.py 100.00% <100.00%> (ø)
pueblo/util/environ.py 100.00% <100.00%> (ø)
pueblo/util/logging.py 100.00% <100.00%> (ø)
pueblo/nlp/resource.py 77.50% <77.50%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Error: Could not find or load main class org.gradle.wrapper.GradleWrapperMain
Caused by: java.lang.ClassNotFoundException: org.gradle.wrapper.GradleWrapperMain
tests/test_ngr.py::test_ngr_sample[ngr/java-gradle] FAILED

Tested on both version 11 and version 17.
@amotl amotl changed the title Iteration +1 Iteration +1: pueblo.nlp.CachedWebResource and pueblo.ngr Oct 30, 2023
@amotl amotl marked this pull request as ready for review October 30, 2023 09:56
@amotl amotl merged commit 51b7716 into main Oct 30, 2023
1 check passed
@amotl amotl deleted the develop branch October 30, 2023 09:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant