Skip to content
This repository has been archived by the owner on Dec 20, 2023. It is now read-only.

Compatibility with Symfony 4 #15

Merged
merged 1 commit into from
Jan 10, 2018
Merged

Compatibility with Symfony 4 #15

merged 1 commit into from
Jan 10, 2018

Conversation

bartosz-maciaszek
Copy link
Contributor

Hi, I wanted to use the library with Symfony 4, but it turned out it supports ~2.3 and ~3.0 only. This is a quick fix to make it working with ~4.0.

@othillo
Copy link
Member

othillo commented Jan 9, 2018

Nice, we do have to update .travis.yml though to actually run the tests with Symfony 4.

@bartosz-maciaszek
Copy link
Contributor Author

That won't be as simple as adding - SYMFONY_VERSION="4.0.*" as Sf4 requires at least PHP 7.1.3. Any idea how to do it neatly?

@othillo
Copy link
Member

othillo commented Jan 10, 2018

I will pick it up in #16

@othillo othillo merged commit 549e589 into qandidate-labs:master Jan 10, 2018
@othillo
Copy link
Member

othillo commented Jan 10, 2018

thank you, @bartosz-maciaszek !

@bartosz-maciaszek bartosz-maciaszek deleted the symfony4 branch January 10, 2018 20:44
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants