Move torrent storages one by one #12035
Conversation
glassez
force-pushed
the
move-storage
branch
from
f445a5e to
a1d6570
Compare
|
Oof, this is one meaty PR, even has changes to the state machine by the looks of it... I will test later and report back. Just out of curiosity, I did not look at the code yet, but does this fix #12040 by any chance or will it at least play nicely with a fix for it? |
glassez
force-pushed
the
move-storage
branch
from
a1d6570 to
c2a5643
Compare
|
Is 4.1.10 going to be a thing? If it is can we get this in there? |
glassez
force-pushed
the
move-storage
branch
from
c2a5643 to
407d16e
Compare
glassez
force-pushed
the
move-storage
branch
from
407d16e to
e4ff206
Compare
|
I'm still sure it would be better to implement it in libtorrent, but I don't have the opportunity to do it seriously yet, so let's settle for this solution. |
There was a problem hiding this comment.
I'm still sure it would be better to implement it in libtorrent, but I don't have the opportunity to do it seriously yet, so let's settle for this solution.
Does anyone have arguments to delay its merge until later releases?
From my testing everything seems OK. From my part, this can be part of the next release.
Side note: we already have a ton of fixes ready for commonly reported problems with 4.2.1. Why not release the new version sooner, rather than later? More fixes can ship in the release after that, let's not delay 4.2.2 any longer. IMO, the only real blocker are the recent libtorrent tracker/DHT/VPN connectivity issues, which are all being fixed for 1.2.5. Once that is out, I think qBittorrent 4.2.2 should be released as well.
|
Not even sure you need to wait for 1.2.5, just build against the latest code. Those DHT/VPN issues have apparently been resolved. @arvidn any point in waiting for 1.2.5? |
|
regarding moving files in parallel. Would anyone be interested in testing this patch? arvidn/libtorrent#4398 |
|
this patch to qbt is probably better though, come to think of it. As it's fixing the problem explicitly |
|
@Ryrynz See this comment: arvidn/libtorrent#4388 (comment) Once those issues are fixed, a new qBittorrent version could be released. This can happen regardless of waiting for the official cut of libtorrent 1.2.5, but I fully expect the release of 1.2.5 to coincide with the fixing of those issues, given their relevance. |
|
Seems 1.25 is only some days off roughly anyway. There's still some connectivity issues with 1.2.5, recommend Sledge waiting until this is fixed before releasing 4.2.2, would be nice if he was available within a short timeframe of Libtorrent being fixed of this issue as many are waiting on this release. |
|
Well, let's start with it. |
|
Actually it produces two different substates: Moving and Queued for moving. Seems we should really distinguish them (at least to show it to user). What do you say? |
I think that helps users to understand what qbt is doing, might be a good idea. |
Closes #9407.