Feat/add abstractrenderview #60159
Open
Feat/add abstractrenderview #60159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
benoitdm-oslandia
force-pushed
the
feat/add_abstractrenderview
branch
from
18fac38 to
c665d88
Compare
wonder-sk
reviewed
Feb 9, 2025
There was a problem hiding this comment.
Thanks for updating the pull request. The design of the abstract render view class looks OK to me now, I have left various comments regarding the implementation details.
Thanks for the patience with my reviews, I know I am slow, but this is a lot of changes to digest...
benoitdm-oslandia
force-pushed
the
feat/add_abstractrenderview
branch
from
e86f599 to
a6e1fb4
Compare
benoitdm-oslandia
force-pushed
the
feat/add_abstractrenderview
branch
3 times, most recently
from
15e4c18 to
8c658d5
Compare
|
@wonder-sk gentle ping! I will rebase and push asap |
benoitdm-oslandia
force-pushed
the
feat/add_abstractrenderview
branch
from
8c658d5 to
3255a19
Compare
rename QgsFramegraphUtils to QgsFrameGraphUtils
Co-authored-By: Mike Krus <mike.krus@kdab.com>
…class feat(3daxis): move camera creations into render view fix(qgs3daxissettings): add checks in readXml to avoid disabled axis view When the project is saved in an old version, minViewportRatio or maxViewportRatio can have bad saved data (ie. 0 values) leading to always disable axis view.
…w class feat(3d/shadow): move shadow setting updates from qgs3dmapscene into render view
benoitdm-oslandia
force-pushed
the
feat/add_abstractrenderview
branch
from
3255a19 to
3e6ac76
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of qgis/QGIS-Enhancement-Proposals#259 QEP (relates to qgis/QGIS-Enhancement-Proposals#252).
It introduces the
AbstractRenderviewconcept to split the framegraph into a more modular way.As many files will be introduced, we move all framegraph related files in a new subdirectory
framegraph.As examples, we extracted 3 renderviewes: one for the 3dAxis, one for the forward and one for the shadows.
cc @ptitjano @mkrus
Funded by CEA/DAM @renardf