[3D] Point cloud editing paintbrush tool #60386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR builds on work done in #60378 |
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
|
I have tried this tool. Very nice addition. Some usability issues:
|
|
Paintbrush tool now supports cancellation of selection while still dragging by pressing |
Withalion
force-pushed
the
point-cloud-paintbrush
branch
from
e04fc42 to
2390c81
Compare
Withalion
force-pushed
the
point-cloud-paintbrush
branch
2 times, most recently
from
1ea0a73 to
c820483
Compare
# Conflicts: # src/3d/qgsrubberband3d.cpp # src/3d/qgsrubberband3d.h
Qgs3DMapToolPointCloudChangeAttribute becomes new base class for polygon tool and paintbrush tool. Processing method has been moved to new Qgs3DEditUtils class.
Withalion
force-pushed
the
point-cloud-paintbrush
branch
from
c820483 to
8b8c856
Compare
Crash occurs when edit tool is active and 3D window is closed
wonder-sk
reviewed
Mar 3, 2025
Withalion
force-pushed
the
point-cloud-paintbrush
branch
from
2502519 to
e8e2141
Compare
wonder-sk
approved these changes
Mar 5, 2025
Withalion
force-pushed
the
point-cloud-paintbrush
branch
from
e8e2141 to
d92cd12
Compare
Withalion
force-pushed
the
point-cloud-paintbrush
branch
from
d92cd12 to
61435a9
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds new tool for editing point clouds. The new tool supports free movement, size change, highlighting of already selected area. Users can change the size of selection area by scrolling and the tool starts selecting on left click + drag. Cursor also shows loading while the point cloud is edited.
Screencast_20250131_193039.mp4
Funded by: Klimadatastyrelsen, Septima