Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[ux] Fix and harmonize drag and drop in Graduated, Categorized and Point Cloud classification symbol lists #60546

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

gacarrillor
Copy link
Member

@gacarrillor gacarrillor commented Feb 11, 2025

This PR fixes an annoying and longstanding issue with drag and drop in Graduated and Categorized symbol lists.
Namely, when attempting to move an item and realizing it would end up in the last position (i.e., being appended).

BEFORE:

dragndrop_symbology_before.mp4

AFTER:

dragndrop_symbology_after.mp4

BONUS:
It also happens in Point Clouds --> Layer Styling --> Classification. This PR also fixes that one.

Fix #50823
Fix #55267
Fix #60559

EXTRA BONUS:

  • Harmonize drag and drop of multiple items: sort them because they may come unsorted due to selection order, which then makes it lose the order after the drop. (Unreported so far).
  • Harmonize selection after drag and drop: Clear selection in Point Clouds classification list.

@github-actions github-actions bot added this to the 3.42.0 milestone Feb 11, 2025
@gacarrillor gacarrillor added GUI/UX Related to QGIS application GUI or User Experience Symbology Related to vector layer symbology or renderers Bug Either a bug report, or a bug fix. Let's hope for the latter! backport release-3_40 labels Feb 11, 2025
Copy link

github-actions bot commented Feb 11, 2025

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit a7a9d3c)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit a7a9d3c)

…pend to the end when dropping an item between other items (fix qgis#50823)
… the end when dropping an item between other items (fix qgis#60559)
…eing dragged are properly sorted to guarantee that they keep the same relative order when dropped (i.e., higher items before being dragged, will remain higher with respect to other dragged items after the drop).
@gacarrillor gacarrillor changed the title [ux] In graduated and categorized symbol lists, make sure we don't append when dropping an item between other items [ux] Harmonize drag and drop in Graduated, Categorized and Point Cloud classification symbol lists Feb 17, 2025
@gacarrillor
Copy link
Member Author

I took the opportunity to add two more changes to finish the harmonization work on drag'n'drops of flat symbol lists.
This PR is ready now :)

@gacarrillor gacarrillor changed the title [ux] Harmonize drag and drop in Graduated, Categorized and Point Cloud classification symbol lists [ux] Fix and harmonize drag and drop in Graduated, Categorized and Point Cloud classification symbol lists Feb 17, 2025
…ed in Point Cloud classification list, clear item selection.
…the approach and perhaps avoid eventual regressions later
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
backport release-3_40 Bug Either a bug report, or a bug fix. Let's hope for the latter! GUI/UX Related to QGIS application GUI or User Experience Point Clouds Symbology Related to vector layer symbology or renderers
Projects
None yet
3 participants