-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[ux] Fix and harmonize drag and drop in Graduated, Categorized and Point Cloud classification symbol lists #60546
Open
gacarrillor
wants to merge
5
commits into
qgis:master
Choose a base branch
from
gacarrillor:fix_50823
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+34
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
…pend to the end when dropping an item between other items (fix qgis#50823)
ac7ec3b
to
b36c7c7
Compare
… the end when dropping an item between other items (fix qgis#60559)
…eing dragged are properly sorted to guarantee that they keep the same relative order when dropped (i.e., higher items before being dragged, will remain higher with respect to other dragged items after the drop).
I took the opportunity to add two more changes to finish the harmonization work on drag'n'drops of flat symbol lists. |
signedav
reviewed
Feb 20, 2025
…ed in Point Cloud classification list, clear item selection.
…the approach and perhaps avoid eventual regressions later
87316a0
to
a7a9d3c
Compare
signedav
approved these changes
Feb 20, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
backport release-3_40
Bug
Either a bug report, or a bug fix. Let's hope for the latter!
GUI/UX
Related to QGIS application GUI or User Experience
Point Clouds
Symbology
Related to vector layer symbology or renderers
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an annoying and longstanding issue with drag and drop in Graduated and Categorized symbol lists.
Namely, when attempting to move an item and realizing it would end up in the last position (i.e., being appended).
BEFORE:
dragndrop_symbology_before.mp4
AFTER:
dragndrop_symbology_after.mp4
BONUS:
It also happens in Point Clouds --> Layer Styling --> Classification. This PR also fixes that one.
Fix #50823
Fix #55267
Fix #60559
EXTRA BONUS: