clang-tidy: Ignore the external directory #60640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
|
@ptitjano did you test that clang-tidy was still able to spot issue in regular folders? |
ptitjano
force-pushed
the
clang-tidy-ignore-external
branch
from
b0db059 to
be8b79b
Compare
|
@troopa81 It looks like the clang-tidy CI does not work at the moment. One get the following error on each inspected file: See for example:
This has nothing to do with the change introduced here. |
The external directory contains code for external librairies. It should not be inspected by clang-tidy. The regex syntax does not allow to directly ignore a directory. Solve this issue by adding a `clang-tidy` config file in the external directory which disables all the checks. See: https://stackoverflow.com/questions/74349432/clang-tidy-exclude-specific-dir-from-analysis See: https://stackoverflow.com/questions/58338202/cmake-clang-tidy-disable-checking-in-directory See: https://gitlab.kitware.com/cmake/cmake/-/merge_requests/777/diffs
ptitjano
force-pushed
the
clang-tidy-ignore-external
branch
from
be8b79b to
0acff83
Compare
This has been solved in #60659 This PR is ready now. |
troopa81
approved these changes
Feb 19, 2025
benoitdm-oslandia
approved these changes
Feb 19, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The external directory contains code for external librairies. It
should not be inspected by clang-tidy.
The regex syntax does not allow to directly ignore a directory. Solve
this issue by adding a
clang-tidyconfig file in the externaldirectory which disables all the checks.
See:
https://stackoverflow.com/questions/74349432/clang-tidy-exclude-specific-dir-from-analysis
See:
https://stackoverflow.com/questions/58338202/cmake-clang-tidy-disable-checking-in-directory
See: https://gitlab.kitware.com/cmake/cmake/-/merge_requests/777/diffs
cc @troopa81 @benoitdm-oslandia