Nominatim Geocoder Locator filter - add countryCodes configuration option #60719
+49
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Backport also to 3.42 |
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
alexbruy
reviewed
Feb 22, 2025
|
|
||
| // Load existing settings | ||
| QgsSettings settings; | ||
| countryCodesEdit->setText( settings.value( "locator_filters/nominatim_geocoder/country_codes", "", QgsSettings::App ).toString() ); |
There was a problem hiding this comment.
Maybe use new settings tree API here and in other places?
There was a problem hiding this comment.
Don't know, I used the code from other Locator filters as example. Like this
I can check this, but not sure what will be better. Is approach I used deprecated?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Configuration option to Nominatim Geocoder Locator filter for filtering results to one or more countries. (Two letter country codes, comma separated). Configuration value is optional, if left blank it will work as now.
Nominatim Geocoder already supports countryCodes parameter so only GUI part and linking setting to request was missing.
Test also supports this parameter so no new tests are created for this.
This change does not effect Batch Nominatim Geocoder processing tool.
Please backport to 3.40
Needs documentation