Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix regression caused by missing exception handling when opening socket #1124

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Fix regression caused by missing exception handling when opening socket #1124

merged 1 commit into from
Apr 7, 2022

Conversation

chinggg
Copy link
Contributor

@chinggg chinggg commented Apr 5, 2022 •
edited
Loading

Checklist

Which kind of PR do you create?

  • This PR only contains minor fixes.
  • This PR contains major feature update.
  • This PR introduces a new function/api for Qiling Framework.

Coding convention?

  • The new code conforms to Qiling Framework naming convention.
  • The imports are arranged properly.
  • Essential comments are added.
  • The reference of the new code is pointed out.

Extra tests?

  • No extra tests are needed for this PR.
  • I have added enough tests for this PR.
  • Tests will be added after some discussion and review.

Changelog?

  • This PR doesn't need to update Changelog.
  • Changelog will be updated after some proper review.
  • Changelog has been updated in my PR.

Target branch?

  • The target branch is dev branch.

One last thing

closes #1122, which is a regression caused by removed exception block in 6989e5a

@chinggg chinggg changed the base branch from master to dev April 5, 2022 11:51
@chinggg chinggg changed the title Fix socket except Fix exception handling when open socket Apr 5, 2022
@chinggg chinggg changed the title Fix exception handling when open socket Fix regression caused by missing exception handling when opening socket Apr 5, 2022
elicn
elicn requested changes Apr 5, 2022
View reviewed changes
qiling/os/posix/syscall/socket.py Outdated Show resolved Hide resolved
qiling/os/posix/syscall/socket.py Outdated Show resolved Hide resolved
@kabeor kabeor merged commit 6b65a26 into qilingframework:dev Apr 7, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kabeor kabeor kabeor approved these changes

@elicn elicn elicn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chinggg @elicn @kabeor