Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix bug: qdb load address error #1364

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

ltlly
Copy link
Contributor

@ltlly ltlly commented Jul 6, 2023

Fix bug: Using ql.run(begin=myaddr) but qdb executes from the entry point of the binary.

Example

When use

ql.debugger = "qdb:0x140086efa"
ql.run(begin=0x140086efa)

image

But it should be
image

Reason

The "begin" parameter is stored in ql.entry_point, but qdb loads only ql.loader.entry_point, and ql.loader.entry_point points to the entry point of the binary

Checklist

Which kind of PR do you create?

  • This PR only contains minor fixes.

Coding convention?

  • The new code conforms to Qiling Framework naming convention.

Extra tests?

  • No extra tests are needed for this PR.

Target branch?

  • The target branch is dev branch.

@elicn elicn requested a review from ucgJhe July 12, 2023 00:15
@elicn
Copy link
Member

elicn commented Jul 12, 2023

@ucgJhe, wanna take a look?

Copy link
Collaborator

@ucgJhe ucgJhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elicn elicn merged commit 930da79 into qilingframework:dev Jul 13, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants