v2 changes #12
Merged
v2 changes #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xen0n
force-pushed
the
no-forced-init
branch
2 times, most recently
from
df9793b to
3737151
Compare
…effect out of main package This is hidden magic, and can subtly change CLI semantics if unknowingly incorporated into an existing codebase (e.g. simple commands with usages like `foo <input file>` will suddenly stop processing the path `version`). Move the init side-effect to separate package so at least this aspect is opt-in.
Otherwise you may assume it's a getter of some versioning structure, while in fact it's just a bunch of printf's.
It doesn't control the main package.
The "N/A" string constant is not exported so it serves little purpose, and not being the zero value it can confuse users used to the typical Go idiom of representing unknown quantities with zero values.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.