This repository has been archived by the owner on Dec 7, 2021. It is now read-only.
Create Eigensolver interface #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manoelmarques
requested review from
levbishop,
pbark and
stefan-woerner
as code owners
manoelmarques
added
the
Changelog: New Feature
woodsp-ibm
reviewed
Sep 27, 2020
There was a problem hiding this comment.
In NumPyEigensolver, as the Eigensolver interface now defines operator and aux_operator setters and getters, and supports_aux_operators too, should we remove the comments from here so they default to teh base class which for supports_aux_operators is for example better documented in the new interface
manoelmarques
force-pushed
the
eigensolver
branch
from
f5640ec to
c9f6177
Compare
|
Yes, I removed the comments. |
manoelmarques
force-pushed
the
eigensolver
branch
from
c9f6177 to
5c3f9a0
Compare
woodsp-ibm
approved these changes
Sep 28, 2020
mtreinish
pushed a commit
to mtreinish/qiskit-core
that referenced
this pull request
Nov 20, 2020
manoelmarques
added a commit
to manoelmarques/qiskit-terra
that referenced
this pull request
Nov 23, 2020
manoelmarques
added a commit
to manoelmarques/qiskit-terra
that referenced
this pull request
Dec 7, 2020
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details and comments