This repository has been archived by the owner on Dec 7, 2021. It is now read-only.
Setting is_measurement for converted state functions and backend arg required to CircuitSampler #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge qiskit-aqua to my fork
2) setting is_measurement for converted state functions 3) new test case in TestStateOpMeasEvals
molar-volume
requested review from
levbishop,
manoelmarques and
woodsp-ibm
as code owners
woodsp-ibm
added
the
Changelog: Bugfix
Cryoris
reviewed
Oct 15, 2020
Comment on lines
86
to
87
| self.assertListEqual(sampler.eval(), | ||
| [[1.0, 0.6987712429686843], [0.7064159097160821, 1.0]]) |
There was a problem hiding this comment.
Comparing to plain numbers is never a good idea 😉 Could you change this to just test if the first operand is still a measurement after going through the circuit sampler? Otherwise LGTM.
There was a problem hiding this comment.
But other tests in the module compare .eval() result to plain numbers.
There was a problem hiding this comment.
@Cryoris I changed the unit test in the way you suggested. Thanks for review.
Cryoris
reviewed
Oct 15, 2020
releasenotes/notes/fix-is-measurements-in-circuit-sampler-18679ad9bfe3f9cb.yaml
Outdated
Show resolved
Hide resolved
…9ad9bfe3f9cb.yaml
Cryoris
previously approved these changes
Oct 15, 2020
woodsp-ibm
previously approved these changes
Oct 15, 2020
woodsp-ibm
approved these changes
Oct 15, 2020
mtreinish
pushed a commit
to mtreinish/qiskit-core
that referenced
this pull request
Nov 20, 2020
…required to CircuitSampler (qiskit-community/qiskit-aqua#1344) * 1) backend arg required to CircuitSampler 2) setting is_measurement for converted state functions 3) new test case in TestStateOpMeasEvals * test if is_measurement correctly propagated in CircuitSampler * test_is_measurement_correctly_propagated simplified * release note added Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> Co-authored-by: Julien Gacon <gaconju@gmail.com>
manoelmarques
pushed a commit
to manoelmarques/qiskit-terra
that referenced
this pull request
Dec 2, 2020
…required to CircuitSampler (qiskit-community/qiskit-aqua#1344) * 1) backend arg required to CircuitSampler 2) setting is_measurement for converted state functions 3) new test case in TestStateOpMeasEvals * test if is_measurement correctly propagated in CircuitSampler * test_is_measurement_correctly_propagated simplified * release note added Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> Co-authored-by: Julien Gacon <gaconju@gmail.com>
manoelmarques
pushed a commit
to manoelmarques/qiskit-terra
that referenced
this pull request
Dec 7, 2020
…required to CircuitSampler (qiskit-community/qiskit-aqua#1344) * 1) backend arg required to CircuitSampler 2) setting is_measurement for converted state functions 3) new test case in TestStateOpMeasEvals * test if is_measurement correctly propagated in CircuitSampler * test_is_measurement_correctly_propagated simplified * release note added Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> Co-authored-by: Julien Gacon <gaconju@gmail.com>
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
resolves #1338
resolves #1339
Details and comments