Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Drop pandas requirement restriction #174

Merged
merged 5 commits into from
Jun 16, 2022
Merged

Drop pandas requirement restriction #174

merged 5 commits into from
Jun 16, 2022

Conversation

burgholzer
Copy link
Contributor

Summary

It should be safe to drop the restriction on the pandas dependency that was introduced because of #133 by using the most recent version of yfinance.

Details and comments

The bug that broke yfinance upon upgrading to pandas>=1.4.0 (see #133) has been fixed in the release of version 0.1.70 (see https://github.com/ranaroussi/yfinance/releases/tag/0.1.70 and the corresponding issue ranaroussi/yfinance#937). As such, it should be safe to drop the restriction and permit newer versions of pandas.

@CLAassistant
Copy link

CLAassistant commented Jun 13, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Jun 13, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2506429974

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.514%
Totals Coverage Status
Change from base Build 2462575367: 0.0%
Covered Lines: 694
Relevant Lines: 831
💛 - Coveralls

@manoelmarques manoelmarques added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Jun 16, 2022
manoelmarques
manoelmarques previously approved these changes Jun 16, 2022
View reviewed changes
@manoelmarques manoelmarques self-requested a review June 16, 2022 03:02
@manoelmarques manoelmarques merged commit 8e1753f into qiskit-community:main Jun 16, 2022
mergify bot pushed a commit that referenced this pull request Jun 16, 2022
@burgholzer @mergify
Drop pandas requirement restriction (#174)
4263b22 
* drop pandas requirement restriction

* Add release notes

Co-authored-by: Manoel Marques <manoel.marques@ibm.com>
(cherry picked from commit 8e1753f)
@mergify mergify bot mentioned this pull request Jun 16, 2022
Merged
@burgholzer burgholzer deleted the drop-pandas-restriction branch June 16, 2022 14:10
mergify bot added a commit that referenced this pull request Jun 16, 2022
@mergify @burgholzer
Drop pandas requirement restriction (#174) (#176)
8c11682 
* drop pandas requirement restriction

* Add release notes

Co-authored-by: Manoel Marques <manoel.marques@ibm.com>
(cherry picked from commit 8e1753f)

Co-authored-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@manoelmarques manoelmarques manoelmarques approved these changes

@woodsp-ibm woodsp-ibm woodsp-ibm approved these changes

@stefan-woerner stefan-woerner Awaiting requested review from stefan-woerner stefan-woerner is a code owner

@pbark pbark Awaiting requested review from pbark

Assignees
No one assigned
Labels
stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@burgholzer @CLAassistant @coveralls @manoelmarques @woodsp-ibm