Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix cr-sections inside sections (eg. when h2 is used) #123

Merged
merged 5 commits into from
Nov 3, 2024

Conversation

jimjam-slam
Copy link
Collaborator

Reverts commits from #82 only sending .page-columns.page-full up to direct parents — now they go all the way back up to main. Fixes the width I the Minard demo, where the .cr-section is inside a section due to the use of an h2.

Also bumps version to 1.0.1!

@jimjam-slam
Copy link
Collaborator Author

Have also incorporated the sidebar-right fix suggested by @lattaai1 (but done properly on the SCSS).

Copy link
Contributor

@andrewpbray andrewpbray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jimjam-slam jimjam-slam merged commit e615011 into dev Nov 3, 2024
1 check passed
@jimjam-slam jimjam-slam deleted the jimjam-slam/issue121 branch November 3, 2024 03:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants