Revise ojs map #65
Merged
Revise ojs map #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewpbray
commented
Aug 5, 2024
|
@jimjam-slam Here is a second way to pass progress to ojs variables. One nice thing about the spanning block approach is that it doesn't seem to suffer from the stuttering that happens is you quickly scroll through the triggers in the second example. Let me know your thoughts. It feels a bit fragile to move towards wrapping some triggers in an additional Div and not others, but I haven't found any induced bugs so far... 🤞 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a
crProgressBlockojs variable that is tracked a separate scroller and is tied to a.progress-blockdiv that can wrap triggers.