Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Bug] uart.c has wrong arguments #15675

Closed
exentio opened this issue Dec 30, 2021 · 1 comment
Closed

[Bug] uart.c has wrong arguments #15675

exentio opened this issue Dec 30, 2021 · 1 comment

Comments

@exentio
Copy link

exentio commented Dec 30, 2021

Describe the Bug

The uart_write() function in uart.c had a wrong argument (c instead of data).
During compilation the error was

Compiling: platforms/chibios/drivers/uart.c                                                        In file included from ./lib/chibios/os/hal/include/hal.h:136,
                 from platforms/chibios/drivers/uart.h:21,
                 from platforms/chibios/drivers/uart.c:17:
platforms/chibios/drivers/uart.c: In function 'uart_write':
platforms/chibios/drivers/uart.c:46:55: error: 'c' undeclared (first use in this function); did you mean 'ch'?
   46 | void uart_write(uint8_t data) { sdPut(&SERIAL_DRIVER, c); }
        |      

Manually changing the argument solved the issue. The bug originated from commit 04b51e381e2ff3f4c7aba662e1c817ce5daa931d.

System Information

  • QMK Firmware version: 0.15.11
@zvecr
Copy link
Member

zvecr commented Feb 13, 2022

Fixed by #16348

@zvecr zvecr closed this as completed Feb 13, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants