Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added support to STM32F103x6 (Low Density) MCUs, fixed UART bug #15724

Closed
wants to merge 3 commits into from
Closed

Added support to STM32F103x6 (Low Density) MCUs, fixed UART bug #15724

wants to merge 3 commits into from

Conversation

exentio
Copy link

@exentio exentio commented Jan 3, 2022

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

#15297
#15675

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jan 3, 2022
@sigprof
Copy link
Contributor

sigprof commented Jan 3, 2022

This should probably be split into two separate PRs.

For the UART change you may argue that it can go directly into master as an obvious bugfix. The existing code does not even compile, but apparently it was never actually used by any of the keyboards tested by CI, so the bug went through unnoticed.

The F103x6 change should go into the develop branch, as it requires a corresponding ChibiOS update. But actually it might need to wait for either a proper 20.3.5 stable release, or a major ChibiOS upgrade (the F103x6 USB fix just made it into the ChibiOS 21.11.1 release, but any attempts to upgrade the code to that release are currently blocked at least on ChibiOS-Contrib not having support for 21.11.1). In general, QMK does not cherry pick patches into ChibiOS (but in this particular case the required patch seems to be already in the 20.3.x stable branch, just not in a release).

@exentio
Copy link
Author

exentio commented Jan 3, 2022

I had thought of making two different PRs but I wasn't sure about it, I can split them if you think it'd be better to do it.
I made a pull request to the ChibiOS repo (qmk/ChibiOS#1) since the changes are very small, but I don't know how often or for which reasons it gets updated.

@zvecr zvecr changed the base branch from master to develop January 3, 2022 20:40
@zvecr
Copy link
Member

zvecr commented Jan 3, 2022

Also, qmk/ChibiOS#1 wont be accepted, as we do not want to maintain any cherry picks. Any changes will have to target upstream, and picked up when we bump chibios in a given develop cycle.

@drashna drashna requested a review from a team January 14, 2022 05:57
@stale
Copy link

stale bot commented Apr 16, 2022

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@drashna drashna closed this Apr 19, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] uart.c has wrong arguments
4 participants